Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unwanted resources from IaC test #139

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Remove unwanted resources from IaC test #139

merged 1 commit into from
Jan 21, 2021

Conversation

eliecharra
Copy link
Contributor

Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #...
❓ Documentation no

Description

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.

@eliecharra eliecharra requested a review from a team as a code owner January 21, 2021 09:58
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #139 (24ae387) into main (db39f7e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   67.51%   67.51%           
=======================================
  Files         175      175           
  Lines        3987     3987           
=======================================
  Hits         2692     2692           
  Misses       1000     1000           
  Partials      295      295
Impacted Files Coverage Ξ”
pkg/resource/aws/aws_route_table_ext.go 33.33% <0.00%> (-22.23%) ⬇️
pkg/parallel/parallel_runner.go 72.91% <0.00%> (+4.16%) ⬆️

wbeuil
wbeuil approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@eliecharra eliecharra merged commit b83c622 into main Jan 21, 2021
@eliecharra eliecharra deleted the cleanup_route_state_tests branch January 21, 2021 10:52
@eliecharra eliecharra added the kind/maintenance Refactoring or changes to the workspace label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbeuil wbeuil wbeuil approved these changes

Assignees
No one assigned
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliecharra @wbeuil