Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only send one alert for computed fieds #141

Merged
merged 3 commits into from
Jan 22, 2021
Merged

Conversation

moadibfr
Copy link
Contributor

Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break yes
πŸ”— Related issues .
❓ Documentation no

Description

Change driftctl behavior when it find drift on computed field.
We use to send one alert per computed field and have a separate method to display only one alert on console output.
This pr will change that so only one alert is sent and all alerts are displayed on console output (like on the json output).

image

@moadibfr moadibfr requested a review from a team as a code owner January 22, 2021 11:24
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #141 (e470757) into main (c9192c3) will decrease coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   67.80%   67.46%   -0.35%     
==========================================
  Files         185      175      -10     
  Lines        4200     3980     -220     
==========================================
- Hits         2848     2685     -163     
+ Misses       1044     1000      -44     
+ Partials      308      295      -13     
Impacted Files Coverage Ξ”
pkg/analyser/analyzer.go 94.02% <100.00%> (-0.34%) ⬇️
pkg/cmd/scan/output/console.go 100.00% <100.00%> (ΓΈ)
pkg/cmd/driftctl.go 72.54% <0.00%> (-1.04%) ⬇️
pkg/driftctl.go 0.00% <0.00%> (ΓΈ)
pkg/remote/aws/init.go 0.00% <0.00%> (ΓΈ)
pkg/iac/deserializers.go 100.00% <0.00%> (ΓΈ)
pkg/middlewares/aws_nat_gateway_eip_assoc.go
.../aws/deserializer/internet_gateway_deserializer.go
...ource/aws/deserializer/nat_gateway_deserializer.go
pkg/remote/aws/nat_gateway_supplier.go
... and 6 more

@eliecharra eliecharra added the kind/maintenance Refactoring or changes to the workspace label Jan 22, 2021
Copy link
Contributor

@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice πŸ‘πŸ» Only a minor remark

pkg/analyser/analyzer.go Outdated Show resolved Hide resolved
@eliecharra eliecharra merged commit 305f1cf into main Jan 22, 2021
@eliecharra eliecharra deleted the fea/send_one_aler_computed branch January 22, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants