Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hint from the diagnostic output #1449

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Remove hint from the diagnostic output #1449

merged 1 commit into from
Mar 29, 2022

Conversation

eliecharra
Copy link
Contributor

Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues none
❓ Documentation no

Description

We have decided to remove hint from there since they do not make sense anymore when displayed under Snyk CLI.
Another option could be to introduce a --no-hint flag or maybe reuse the actual --quiet flag.
Wrapping that in the --quiet flag have the drawback of loosing the progress bar and other useful diagnostic messages.

@eliecharra eliecharra added the kind/enhancement New feature or improvement label Mar 29, 2022
@eliecharra eliecharra requested a review from a team as a code owner March 29, 2022 09:26
@eliecharra eliecharra requested review from craigfurman and removed request for a team March 29, 2022 09:26
@eliecharra eliecharra merged commit dd64918 into main Mar 29, 2022
@eliecharra eliecharra deleted the chore/remove_hints branch March 29, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants