Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for iam_group_policy #1458

Merged
merged 1 commit into from
Apr 4, 2022
Merged

feat: add support for iam_group_policy #1458

merged 1 commit into from
Apr 4, 2022

Conversation

eliecharra
Copy link
Contributor

Q A
🐛 Bug fix? no
🚀 New feature? yes
⚠ Deprecations? no
❌ BC Break no
🔗 Related issues #1408
❓ Documentation snyk/driftctl-docs#232

@eliecharra eliecharra requested a review from a team as a code owner April 1, 2022 13:38
@eliecharra eliecharra requested review from francescomari, a team and wbeuil and removed request for a team and francescomari April 1, 2022 13:38
@eliecharra eliecharra force-pushed the feat/add_aws_iam_group_policy branch from 9e55538 to bbedd47 Compare April 1, 2022 13:42
wbeuil
wbeuil approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliecharra eliecharra added the kind/enhancement New feature or improvement label Apr 4, 2022
@eliecharra eliecharra merged commit 2e31ee5 into main Apr 4, 2022
@eliecharra eliecharra deleted the feat/add_aws_iam_group_policy branch April 4, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbeuil wbeuil wbeuil approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliecharra @wbeuil