Add aws_iam_group #1477
Merged
Add aws_iam_group #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundowndev-snyk
force-pushed
the
feat/add_aws_iam_group
branch
3 times, most recently
from
d03b6f3
to
c55e8e9
Compare
eliecharra
suggested changes
May 9, 2022
There was a problem hiding this comment.
There is some issues with the acceptance test, the diff said that you renamed pkg/resource/aws/testdata/acc/aws_iam_group_policy/.terraform.lock.hcl to pkg/resource/aws/testdata/acc/aws_iam_group/.terraform.lock.hcl. We should keep the lock for those two tests.
pkg/resource/aws/testdata/acc/aws_iam_group_policy/.driftignore
Outdated
Show resolved
Hide resolved
sundowndev-snyk
force-pushed
the
feat/add_aws_iam_group
branch
from
c55e8e9
to
6ad889c
Compare
Codecov Report
@@ Coverage Diff @@
## main #1477 +/- ##
==========================================
+ Coverage 75.07% 82.06% +6.99%
==========================================
Files 512 438 -74
Lines 19195 15907 -3288
==========================================
- Hits 14410 13054 -1356
+ Misses 4476 2537 -1939
- Partials 309 316 +7
|
eliecharra
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the
aws_iam_groupresource.Docs PR snyk/driftctl-docs#239