fix: google_compute_global_forwarding_rule acc test #1514
Conversation
sundowndev-snyk
added
the
kind/maintenance
Codecov Report
@@ Coverage Diff @@
## main #1514 +/- ##
==========================================
+ Coverage 72.37% 81.79% +9.41%
==========================================
Files 514 439 -75
Lines 19338 16008 -3330
==========================================
- Hits 13996 13093 -903
+ Misses 5003 2598 -2405
+ Partials 339 317 -22
|
| @@ -17,6 +18,8 @@ func TestAcc_Google_ComputeGlobalForwardingRule(t *testing.T) { | |||
| }, | |||
| Checks: []acceptance.AccCheck{ | |||
| { | |||
| // New resources are not visible immediately through GCP API after an apply operation. | |||
| ShouldRetry: acceptance.LinearBackoff(10 * time.Minute), | |||
There was a problem hiding this comment.
is that 10 minutes? quite long isn't it? from your experience it makes sense?
There was a problem hiding this comment.
We could probably switch it to 5min, but it's not that important because if in real life if it took less we'll get out of this without waiting 10 mins.
It's more like if we can do more we can do less in that case.
There was a problem hiding this comment.
10 minutes is a reasonable time frame for an acceptance test IMO. Running the whole test suite takes more than 50 mins. Also like @eliecharra said, this is just a limit. In this case, 10 minutes belongs to 3 retries, while 5 minutes belongs to 2 retries.
sundowndev-snyk
deleted the
fix/google_compute_global_forwarding_rule_acc_test
branch
Description
This is an attempt to fix a failure in our acceptance test.