Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display better message when AWS credentials missing #1515

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

eliecharra
Copy link
Contributor

@eliecharra eliecharra commented Jun 3, 2022

Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues CFG-1917
❓ Documentation no

Description

Display a more human readable error message when AWS credentials are missing

image

@eliecharra eliecharra added the kind/enhancement New feature or improvement label Jun 3, 2022
@eliecharra eliecharra requested a review from a team as a code owner June 3, 2022 08:34
@eliecharra eliecharra requested review from sundowndev-snyk and removed request for a team June 3, 2022 08:34
@codecov-commenter
Copy link

Codecov Report

Merging #1515 (f9ce34d) into main (0786e71) will increase coverage by 6.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1515      +/-   ##
==========================================
+ Coverage   75.61%   81.71%   +6.10%     
==========================================
  Files         514      439      -75     
  Lines       19338    16023    -3315     
==========================================
- Hits        14622    13093    -1529     
+ Misses       4415     2613    -1802     
- Partials      301      317      +16     
Impacted Files Coverage Ξ”
pkg/remote/aws/init.go 0.00% <0.00%> (-96.02%) ⬇️
pkg/remote/aws/provider.go 45.83% <0.00%> (-37.96%) ⬇️
pkg/terraform/plugin_client.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/remote/aws/client/s3_client_factory.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/resource/azurerm/azurerm_image.go 12.50% <0.00%> (-87.50%) ⬇️
pkg/resource/azurerm/azurerm_resource_group.go 12.50% <0.00%> (-87.50%) ⬇️
pkg/resource/azurerm/azurerm_container_registry.go 12.50% <0.00%> (-87.50%) ⬇️
pkg/resource/google/google_compute_address.go 14.28% <0.00%> (-85.72%) ⬇️
...g/resource/google/google_compute_global_address.go 14.28% <0.00%> (-85.72%) ⬇️
... and 185 more

@eliecharra eliecharra merged commit 25f5080 into main Jun 7, 2022
@eliecharra eliecharra deleted the feat/handle_aws_missing_creds branch June 7, 2022 08:34
sundowndev-snyk added a commit that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants