Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Stop failing issue tagging on invalid issue links #1546

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

chdorner-snyk
Copy link
Contributor

@chdorner-snyk chdorner-snyk commented Jun 16, 2022

Description

The script was detecting JIRA issue links as GH issues and subsequently failing when checking that a GH issue with the same ID exists (example of a failure here).

Given we seem to have a mix of GH and JIRA issue links, we can just not fail the job if no GH issue can be found for a certain ID.

@chdorner-snyk chdorner-snyk requested a review from a team as a code owner June 16, 2022 13:53
@chdorner-snyk chdorner-snyk requested review from sundowndev-snyk and removed request for a team June 16, 2022 13:53
@chdorner-snyk chdorner-snyk changed the title chore: Only detect GH issues in tagging script chore: Stop failing issue tagging on invalid issue links Jun 16, 2022
Copy link
Contributor

@sundowndev-snyk sundowndev-snyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for spending some time on this 🙏

@sundowndev-snyk sundowndev-snyk merged commit 0afdf95 into main Jun 17, 2022
@sundowndev-snyk sundowndev-snyk deleted the chore/gh-issue-tagging branch June 17, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants