Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: share provider schema for goldenfile test #1573

Merged
merged 2 commits into from
Aug 2, 2022
Merged

chore: share provider schema for goldenfile test #1573

merged 2 commits into from
Aug 2, 2022

Conversation

moadibfr
Copy link
Contributor

@moadibfr moadibfr commented Aug 1, 2022

Q A
🐛 Bug fix? no
🚀 New feature? no
⚠ Deprecations? no
❌ BC Break no
🔗 Related issues
❓ Documentation no

Description

remove all duplicated provider schema and used shared one in test folder

@moadibfr moadibfr marked this pull request as ready for review August 2, 2022 13:04
@moadibfr moadibfr requested a review from a team as a code owner August 2, 2022 13:04
@moadibfr moadibfr requested review from craigfurman and eliecharra and removed request for a team August 2, 2022 13:04
craigfurman
craigfurman approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@craigfurman craigfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that line diff count

@moadibfr moadibfr merged commit cf9dba0 into main Aug 2, 2022
@moadibfr moadibfr deleted the chore/shared_schema_tests branch August 2, 2022 13:23
@eliecharra eliecharra added the kind/maintenance Refactoring or changes to the workspace label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigfurman craigfurman craigfurman approved these changes

@eliecharra eliecharra Awaiting requested review from eliecharra

Assignees
No one assigned
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moadibfr @craigfurman @eliecharra