Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CODEOWNERS team name #1574

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Fix CODEOWNERS team name #1574

merged 1 commit into from
Aug 2, 2022

Conversation

craigfurman
Copy link
Contributor

@craigfurman craigfurman commented Aug 2, 2022

Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #...
❓ Documentation no

Description

https://github.com/snyk/driftctl/blob/main/.github/CODEOWNERS was showing "this codeowners file contains errors". I think it all still works, presumably redirecting to https://github.com/orgs/snyk/teams/cloud-context, but this is a fix for a very minor broken window.

Nope, the auto-assignment doesn't work, presumably because of the broken codeowners name!

@codecov-commenter
Copy link

Codecov Report

Merging #1574 (a12285c) into main (d4cc400) will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1574      +/-   ##
==========================================
- Coverage   79.17%   78.86%   -0.32%     
==========================================
  Files         226      219       -7     
  Lines        7079     6918     -161     
==========================================
- Hits         5605     5456     -149     
+ Misses       1271     1266       -5     
+ Partials      203      196       -7     
Impacted Files Coverage Ξ”
pkg/resource/github/github_team.go 50.00% <0.00%> (-50.00%) ⬇️
pkg/output/printer.go 55.55% <0.00%> (-44.45%) ⬇️
pkg/resource/github/github_branch_protection.go 21.42% <0.00%> (-42.86%) ⬇️
pkg/cmd/scan.go 65.01% <0.00%> (-24.79%) ⬇️
pkg/iac/supplier/IacChainSupplier.go 76.08% <0.00%> (-13.05%) ⬇️
pkg/iac/terraform/state/terraform_state_reader.go 63.01% <0.00%> (-8.22%) ⬇️
pkg/analyser/analysis.go 90.86% <0.00%> (-5.92%) ⬇️
pkg/cmd/scan/output/output.go 88.23% <0.00%> (-3.93%) ⬇️
pkg/output/progress.go 89.74% <0.00%> (-3.85%) ⬇️
pkg/resource/mock_Supplier.go
... and 6 more

@craigfurman craigfurman merged commit 243f2ed into main Aug 2, 2022
@craigfurman craigfurman deleted the fix-code-owner-team-name branch August 2, 2022 10:19
@eliecharra eliecharra added the kind/maintenance Refactoring or changes to the workspace label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants