fea: transform alert from enum lib into diagnostic

[moadibfr]

Q	A
🐛 Bug fix?	no
🚀 New feature?	no
⚠ Deprecations?	no
❌ BC Break	no
🔗 Related issues
❓ Documentation	no

Description

transform alert from enum lib into diagnostic when using the facade implementing the new api

[codecov-commenter]

Codecov Report

Merging #1579 (c5eec8b) into main (b1cf4b5) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1579      +/-   ##
==========================================
- Coverage   78.70%   78.63%   -0.07%     
==========================================
  Files         219      219              
  Lines        6946     6952       +6     
==========================================
  Hits         5467     5467              
- Misses       1282     1288       +6     
  Partials      197      197              

Impacted Files	Coverage Δ
pkg/analyser/analyzer.go	88.23% <0.00%> (-3.61%)	⬇️
pkg/iac/terraform/state/alerts.go	0.00% <0.00%> (ø)

[craigfurman]

2 non-blocking notes, I'll approve in advance 👍

Before we merge this, I/you/we could test this branch out in snyk-iac-test and see if we can spike out bubbling up these non-fatal errors from diagnostics. WDYT?

[eliecharra]

Before we merge this, I/you/we could test this branch out in snyk-iac-test and see if we can spike out bubbling up these non-fatal errors from diagnostics. WDYT?

100% in sync with that, let's do a small pairing session on that, shoot me an invite 🙏🏻

[craigfurman]

Nice!