Use acceptance tests backoff-retry in more places

[craigfurman]

Q	A
🐛 Bug fix?	yes
🚀 New feature?	no
⚠ Deprecations?	no
❌ BC Break	no
🔗 Related issues	n/a
❓ Documentation	no

Description

Use acceptance tests backoff-retry in more places

Remove RetryFor function, replace all uses of it with ShouldRetry.

[codecov-commenter]

Codecov Report

Merging #1584 (d1a0c63) into main (ed58b6d) will decrease coverage by 2.50%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1584      +/-   ##
==========================================
- Coverage   81.14%   78.63%   -2.51%     
==========================================
  Files         226      219       -7     
  Lines        7113     6952     -161     
==========================================
- Hits         5772     5467     -305     
- Misses       1159     1288     +129     
- Partials      182      197      +15     

Impacted Files	Coverage Δ
pkg/resource/azurerm/azurerm_image.go	12.50% <0.00%> (-87.50%)	⬇️
pkg/resource/azurerm/azurerm_resource_group.go	12.50% <0.00%> (-87.50%)	⬇️
pkg/resource/google/google_compute_address.go	14.28% <0.00%> (-85.72%)	⬇️
...g/resource/google/google_compute_global_address.go	14.28% <0.00%> (-85.72%)	⬇️
...ce/google/google_compute_instance_group_manager.go	14.28% <0.00%> (-85.72%)	⬇️
pkg/resource/google/google_compute_disk.go	16.66% <0.00%> (-83.34%)	⬇️
pkg/resource/google/google_compute_image.go	16.66% <0.00%> (-83.34%)	⬇️
pkg/resource/google/google_bigquery_table.go	16.66% <0.00%> (-83.34%)	⬇️
pkg/resource/google/google_bigquery_dataset.go	16.66% <0.00%> (-83.34%)	⬇️
pkg/resource/google/google_compute_health_check.go	16.66% <0.00%> (-83.34%)	⬇️
... and 28 more