add support for aws s3 account public access block #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moadibfr
requested review from
muratcelep,
eliecharra and
wbeuil
and removed request for
a team
eliecharra
suggested changes
Sep 30, 2022
enumeration/remote/aws/s3_account_public_access_block_enumerator.go
Outdated
Show resolved
Hide resolved
moadibfr
force-pushed
the
fea/add_aws_s3_account_public_access_block
branch
from
6335139
to
d22ff23
Compare
eliecharra
previously approved these changes
Oct 11, 2022
| cache: c, | ||
| } | ||
| } | ||
| func (s *s3ControlRepository) GetAccountID() string { |
There was a problem hiding this comment.
Is this method still used ?
There was a problem hiding this comment.
yeah sorry I pushed an half done thing for you to comment on where the accountid was injected. It's fixed now.
moadibfr
force-pushed
the
fea/add_aws_s3_account_public_access_block
branch
from
d22ff23
to
c94dad7
Compare
eliecharra
approved these changes
Oct 12, 2022
|
After update seems like it could no longer scan my state: Scanned resources |
thanks @JAleksandrov just reproduced that and working on it: #1590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add support for aws s3 account public access block