Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add suport for aws_cloudtrail resources #1593

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Conversation

moadibfr
Copy link
Contributor

Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #
❓ Documentation yes

Description

add suport for aws_cloudtrail resources

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #1593 (00dad50) into main (a28bac9) will decrease coverage by 2.38%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1593      +/-   ##
==========================================
- Coverage   81.04%   78.66%   -2.39%     
==========================================
  Files         226      220       -6     
  Lines        7113     6959     -154     
==========================================
- Hits         5765     5474     -291     
- Misses       1154     1288     +134     
- Partials      194      197       +3     
Impacted Files Coverage Ξ”
pkg/resource/resource_types.go 76.47% <ΓΈ> (ΓΈ)
pkg/resource/aws/aws_cloudtrail.go 100.00% <100.00%> (ΓΈ)
pkg/resource/aws/metadatas.go 100.00% <100.00%> (ΓΈ)
pkg/resource/azurerm/azurerm_container_registry.go 12.50% <0.00%> (-87.50%) ⬇️
pkg/resource/google/google_compute_address.go 14.28% <0.00%> (-85.72%) ⬇️
...g/resource/google/google_compute_global_address.go 14.28% <0.00%> (-85.72%) ⬇️
...ce/google/google_compute_instance_group_manager.go 14.28% <0.00%> (-85.72%) ⬇️
pkg/resource/google/google_compute_disk.go 16.66% <0.00%> (-83.34%) ⬇️
pkg/resource/google/google_compute_image.go 16.66% <0.00%> (-83.34%) ⬇️
pkg/resource/google/google_bigquery_table.go 16.66% <0.00%> (-83.34%) ⬇️
... and 30 more

@moadibfr moadibfr marked this pull request as ready for review October 24, 2022 10:14
@moadibfr moadibfr requested a review from a team as a code owner October 24, 2022 10:14
@moadibfr moadibfr requested review from agatakrajewska, eliecharra and wbeuil and removed request for a team October 24, 2022 10:14
Copy link
Contributor

@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ”₯

@moadibfr moadibfr merged commit 49cdbc8 into main Oct 26, 2022
@moadibfr moadibfr deleted the feat/support_aws_cloudtrail branch October 26, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants