-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glob pattern matching within a GCS backend #1608
Conversation
This reverts commit 1591122.
I've removed the tests and raised a new issue to improve the mocking of Google Cloud clients and APIs. See #1610 |
@@ -15,6 +15,11 @@ func GlobS3(path string) (prefix string, pattern string) { | |||
return | |||
} | |||
|
|||
func GlobGS(path string) (prefix string, pattern string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like this and a good part of the enumeration method is duplicated from the s3 code. Do you think we could find a way to share the mathcing code ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking the same to be honest, I'll take a look at it this evening and see if I can offload some code to common functions ππΌ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved some code around, to a common.go
and removed some wrapper functions that didn't add a lot of value.
Changed nothing in the functionality, just renamed functions and removed duplicate code.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1608 +/- ##
==========================================
- Coverage 85.11% 78.08% -7.03%
==========================================
Files 227 222 -5
Lines 7120 7010 -110
==========================================
- Hits 6060 5474 -586
- Misses 900 1339 +439
- Partials 160 197 +37
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks a lot for your contribution !
Could you also please do some documentation on this on our documentation repo ?
Definitely, will update the PR shortly |
|
@all-contributors please add @bschaatsbergen for code and documentation |
I've put up a pull request to add @bschaatsbergen! π |
Description
Adds the ability to make use of glob pattern matching within the GS Backend.