Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google_compute_ssl_certificate resource #1611

Merged
merged 28 commits into from
Feb 6, 2023
Merged

Add google_compute_ssl_certificate resource #1611

merged 28 commits into from
Feb 6, 2023

Conversation

bschaatsbergen
Copy link
Contributor

@bschaatsbergen bschaatsbergen commented Jan 11, 2023

Q A
πŸ› Bug fix? yes/no
πŸš€ New feature? yes/no
⚠ Deprecations? yes/no
❌ BC Break yes/no
πŸ”— Related issues Closes #1505
❓ Documentation yes

Description

New GCP google_compute_ssl_certificate resource.

@bschaatsbergen
Copy link
Contributor Author

Seems to work fine on a local build
image

@bschaatsbergen bschaatsbergen marked this pull request as ready for review January 16, 2023 16:28
@bschaatsbergen bschaatsbergen requested a review from a team as a code owner January 16, 2023 16:28
@bschaatsbergen bschaatsbergen requested review from moadibfr and removed request for a team January 16, 2023 16:28
@bschaatsbergen bschaatsbergen marked this pull request as draft January 16, 2023 16:28
@bschaatsbergen bschaatsbergen changed the title Add google_compute_ssl_certificate resource Add google_compute_ssl_certificate resource Jan 16, 2023
@bschaatsbergen bschaatsbergen marked this pull request as ready for review January 16, 2023 17:00
@codecov-commenter
Copy link

Codecov Report

Merging #1611 (1e44cef) into main (239f0bb) will decrease coverage by 6.46%.
The diff coverage is n/a.

πŸ“£ This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1611      +/-   ##
==========================================
- Coverage   85.11%   78.66%   -6.46%     
==========================================
  Files         227      220       -7     
  Lines        7120     6959     -161     
==========================================
- Hits         6060     5474     -586     
- Misses        900     1288     +388     
- Partials      160      197      +37     
Impacted Files Coverage Ξ”
pkg/resource/resource_types.go 76.47% <ΓΈ> (ΓΈ)
pkg/resource/azurerm/azurerm_image.go 12.50% <0.00%> (-87.50%) ⬇️
pkg/resource/azurerm/azurerm_resource_group.go 12.50% <0.00%> (-87.50%) ⬇️
pkg/resource/azurerm/azurerm_container_registry.go 12.50% <0.00%> (-87.50%) ⬇️
pkg/resource/aws/aws_route_table_association.go 13.33% <0.00%> (-86.67%) ⬇️
pkg/resource/google/google_compute_address.go 14.28% <0.00%> (-85.72%) ⬇️
...g/resource/google/google_compute_global_address.go 14.28% <0.00%> (-85.72%) ⬇️
...ce/google/google_compute_instance_group_manager.go 14.28% <0.00%> (-85.72%) ⬇️
pkg/resource/aws/aws_lb.go 16.66% <0.00%> (-83.34%) ⬇️
pkg/resource/google/google_compute_disk.go 16.66% <0.00%> (-83.34%) ⬇️
... and 61 more

Copy link
Contributor

@moadibfr moadibfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me thanks a lot for this πŸ™

@moadibfr moadibfr merged commit 3f4586d into snyk:main Feb 6, 2023
@bschaatsbergen bschaatsbergen deleted the google-compute-ssl-cert-support branch February 7, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for google_compute_ssl_certificate
3 participants