Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump go-getter to resolve vuln and go mod tidy #1657

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

karniwl
Copy link
Contributor

@karniwl karniwl commented May 8, 2023

No description provided.

@karniwl karniwl requested a review from a team as a code owner May 8, 2023 13:18
@karniwl karniwl requested review from agatakrajewska and removed request for a team May 8, 2023 13:18
@agatakrajewska agatakrajewska force-pushed the chore/bump-go-getter branch 8 times, most recently from a681502 to 506a700 Compare June 6, 2023 08:49
Replace deprecated archivesreplacements as well.
Copy link
Contributor

@craigfurman craigfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Glad we fixed those acceptance tests in order to feel better about the aws-sdk bump!

@@ -51,7 +52,7 @@ func newAssetClient(fakeServer *FakeAssetServer) (*asset.Client, error) {
client, err := asset.NewClient(ctx,
option.WithEndpoint(fakeServerAddr),
option.WithoutAuthentication(),
option.WithGRPCDialOption(grpc.WithInsecure()),
option.WithGRPCDialOption(grpc.WithTransportCredentials(insecure.NewCredentials())),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

But this diff doesn't make it worse, so this is non-blocking

@agatakrajewska agatakrajewska merged commit 829ead4 into main Jun 6, 2023
@agatakrajewska agatakrajewska deleted the chore/bump-go-getter branch June 6, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants