[CTX-601] chore: always retry terraform-destroy #1664
Merged
+1
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many acceptance test failures are caused by stray resources left behind from previous runs. We think failed terraform-destroy cleanup might be to blame. This commit adds unconditional retry with a long exponential backoff to try to ensure that cleanup can work within cloud provider rate limits, reducing the maintenance burden. Remove RetryConfig, which a small number of tests were using to optionally add retry behaviour.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many acceptance test failures are caused by stray resources left behind from previous runs. We think failed terraform-destroy cleanup might be to blame. This commit adds unconditional retry with a long exponential backoff to try to ensure that cleanup can work within cloud provider rate limits, reducing the maintenance burden.
Remove RetryConfig, which a small number of tests were using to optionally add retry behaviour.