Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource aws_sqs_queue and aws_sqs_queue_policy #170

Merged
merged 3 commits into from
Feb 3, 2021

Conversation

wbeuil
Copy link
Contributor

@wbeuil wbeuil commented Jan 29, 2021

Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #146 #147
❓ Documentation yes

Description

Add resource aws_sqs_queue and aws_sqs_queue_policy.
Be aware of a special case for default sqs queue policy

@wbeuil wbeuil requested a review from a team as a code owner January 29, 2021 11:36
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #170 (0d738f9) into main (9ea6b68) will decrease coverage by 0.17%.
The diff coverage is 66.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   69.70%   69.52%   -0.18%     
==========================================
  Files         190      201      +11     
  Lines        4380     4555     +175     
==========================================
+ Hits         3053     3167     +114     
- Misses       1087     1134      +47     
- Partials      240      254      +14     
Impacted Files Coverage Ξ”
pkg/driftctl.go 0.00% <0.00%> (ΓΈ)
pkg/remote/aws/init.go 0.00% <0.00%> (ΓΈ)
...esource/aws/deserializer/sqs_queue_deserializer.go 53.33% <53.33%> (ΓΈ)
.../aws/deserializer/sqs_queue_policy_deserializer.go 53.33% <53.33%> (ΓΈ)
pkg/remote/aws/sqs_queue_policy_supplier.go 55.55% <55.55%> (ΓΈ)
pkg/remote/aws/sqs_queue_supplier.go 55.55% <55.55%> (ΓΈ)
pkg/resource/aws/aws_sqs_queue_ext.go 60.00% <60.00%> (ΓΈ)
pkg/resource/aws/aws_sqs_queue_policy_ext.go 60.00% <60.00%> (ΓΈ)
pkg/remote/aws/repository/sqs_repository.go 63.63% <63.63%> (ΓΈ)
pkg/middlewares/aws_default_sqs_queue_policy.go 86.36% <86.36%> (ΓΈ)
... and 16 more

@eliecharra eliecharra added the kind/enhancement New feature or improvement label Jan 29, 2021
@wbeuil wbeuil force-pushed the res/aws_sqs_queue branch 3 times, most recently from 45a157e to 737ea85 Compare February 1, 2021 12:57
pkg/middlewares/aws_sqs_queue_policy_expander.go Outdated Show resolved Hide resolved
pkg/remote/aws/sqs_queue_policy_supplier.go Outdated Show resolved Hide resolved
pkg/remote/aws/sqs_queue_supplier.go Outdated Show resolved Hide resolved
pkg/resource/aws/aws_sqs_queue_ext.go Show resolved Hide resolved
@wbeuil wbeuil marked this pull request as draft February 3, 2021 13:54
@wbeuil wbeuil marked this pull request as ready for review February 3, 2021 20:14
@eliecharra eliecharra merged commit dc218e4 into main Feb 3, 2021
@eliecharra eliecharra deleted the res/aws_sqs_queue branch February 3, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for aws_sqs_queue_policy Add support for aws_sqs_queue
3 participants