Embed the environment variables before PreExec in ACC test

[sshota0809]

Q	A
🐛 Bug fix?	yes
🚀 New feature?	no
⚠ Deprecations?	no
❌ BC Break	no
🔗 Related issues	#175
❓ Documentation	no

Description

I fixed #175.
Please review my commit!

[eliecharra]

LGTM, thanks a lot @sshota0809 🎉

[eliecharra]

@sshota0809 Could you remove your fork of driftctl from circleCI ? It prevent our CircleCI check to run on your PR.

https://circleci.com/docs/2.0/oss/#build-pull-requests-from-forked-repositories

[sshota0809]

@eliecharra

I checked the document you gave me, and according to the document,

Note: If a user submits a pull request to your repository from a fork, but no pipeline is triggered, then the user most likely is following a project fork on their personal account rather than the project itself of CircleCi, causing the jobs to trigger under the user’s personal account and not the organization account.
To resolve this issue, have the user unfollow their fork of the project on CircleCI and instead follow the source project.
This will trigger their jobs to run under the organization when they submit pull requests.

But I didn't follow my fork of driftctl on circleCI.

This screen shot is the list of projects.

What should I do? I'm so sorry I'm not familiar with circleCI 😢

[eliecharra]

What a weird behavior from CircleCI ... Can you try to follow our project in circle from this page https://app.circleci.com/projects/project-dashboard/github/cloudskiff/ ?

Then try to update this PR by rebasing it on main

[eliecharra]

@wbeuil Maybe we could open a support ticket for this ?

[wbeuil]

@wbeuil Maybe we could open a support ticket for this ?

I will open a ticket on their side then

[sshota0809]

@eliecharra @wbeuil
Thanks for your help!

This URL seems 404...
https://app.circleci.com/projects/project-dashboard/github/cloudskiff/

[eliecharra]

@sshota0809 We just opened a support ticket on CircleCI.

Thanks for trying to fix this but we don't want you to spend too much time on it. We'll keep you informed when we get some update from Circle 😉

[eliecharra]

Merging since we do not have any response from CircleCI, I've updated the PR onto main to trigger test but this is a weird workaround.

Thanks a lot for your work @sshota0809

[codecov]

Codecov Report

Merging #177 (58be0f9) into main (992b658) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   69.71%   69.71%           
=======================================
  Files         190      190           
  Lines        4379     4379           
=======================================
  Hits         3053     3053           
  Misses       1086     1086           
  Partials      240      240           

[sshota0809]

@eliecharra
Thank you for merging.
I would like to contribute this awesome tool more, so I have to solve this wired issue😢

[wbeuil]

Thanks @sshota0809 for your contribution ! No worry we're gonna find what's blocking. We're still waiting for a response from CircleCI. We'll keep you posted !

[wbeuil]

@sshota0809, CircleCI just came back to us saying that you are following your own forked project and not the main project.

Can you double check that you are not following your forked project in CircleCI, but the cloudskiff/driftctl project?

[sshota0809]

@wbeuil
Thank you for reply.

I have checked that I don't follow my own forked repository for sure. I have an idea now that I will try to delete my own forked repository once, and fork origin repository again.

And after that, if you don't mind I would like to push PR to origin repository as a test to confirm if circleCI test will be kicked correctly. Is that ok?

[wbeuil]

Sure @sshota0809 let's try that !

[sshota0809]

@wbeuil
I have confirmed that CircleCI test was kicked correctly from my new forked repository. Thanks a lot for your support!