Fix false positive drifts on aws_sns_topic #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eliecharra
commented
Feb 8, 2021
eliecharra
commented
| Q | A |
|---|---|
| π Bug fix? | yes |
| π New feature? | no |
| β Deprecations? | no |
| β BC Break | no |
| π Related issues | none |
| β Documentation | no |
wbeuil
approved these changes
Feb 8, 2021
eliecharra
force-pushed
the
fix_default_drift_sns_topic
branch
from
5f7b761
to
2f7fa28
Compare
Codecov Report
@@ Coverage Diff @@
## v0.4 #228 +/- ##
==========================================
+ Coverage 69.79% 69.83% +0.04%
==========================================
Files 215 215
Lines 4813 4823 +10
==========================================
+ Hits 3359 3368 +9
- Misses 1184 1185 +1
Partials 270 270
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.