Add aws_default_vpc and aws_vpc support #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 67.06% 67.00% -0.07%
==========================================
Files 140 146 +6
Lines 3073 3179 +106
==========================================
+ Hits 2061 2130 +69
- Misses 783 809 +26
- Partials 229 240 +11
|
eliecharra
commented
Dec 15, 2020
eliecharra
force-pushed
the
add_default_vpc
branch
from
5dd001a
to
f8e97b3
Compare
eliecharra
force-pushed
the
add_default_vpc
branch
from
f8e97b3
to
37efbde
Compare
eliecharra
force-pushed
the
add_default_vpc
branch
2 times, most recently
from
ecfec35
to
1ca42a2
Compare
eliecharra
force-pushed
the
add_default_vpc
branch
from
1ca42a2
to
35cc32a
Compare
wbeuil
suggested changes
Dec 17, 2020
pkg/remote/aws/vpc_supplier_test.go
Outdated
| IsDefault: aws.Bool(false), | ||
| }, | ||
| }, | ||
| }, true) |
There was a problem hiding this comment.
Shouldn't it be false here ?
There was a problem hiding this comment.
Even though this won't change the test itself and its results, we should make it so that it's logic for reading PR purposes.
There was a problem hiding this comment.
Sure, I've inverted this bool meaning in my mind ππ» nice catch
| return resourceaws.AwsVpcResourceType | ||
| } | ||
|
|
||
| func (s VPCDeserializer) Deserialize(recordList []cty.Value) ([]resource.Resource, error) { |
There was a problem hiding this comment.
You kept the recordList from Route53 records, can you change it to something more inline with vpc, like vpcList and update all the lines below.
There was a problem hiding this comment.
Nice catch, let's update it for something more generic like rawList as we use rawResource as iterator name in the loop.
| return resourceaws.AwsDefaultVpcResourceType | ||
| } | ||
|
|
||
| func (s DefaultVPCDeserializer) Deserialize(recordList []cty.Value) ([]resource.Resource, error) { |
eliecharra
force-pushed
the
add_default_vpc
branch
from
35cc32a
to
864ecc4
Compare
moadibfr
previously approved these changes
Dec 17, 2020
eliecharra
force-pushed
the
add_default_vpc
branch
from
864ecc4
to
bbe91ff
Compare
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
aws_default_vpcaws_vpc