Warn on unmanaged security group rules #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliecharra
approved these changes
Feb 15, 2021
Codecov Report
@@ Coverage Diff @@
## main #261 +/- ##
==========================================
+ Coverage 69.96% 70.01% +0.04%
==========================================
Files 222 222
Lines 4934 4942 +8
==========================================
+ Hits 3452 3460 +8
Misses 1207 1207
Partials 275 275
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unmanaged security group rules can be falsely displayed as unmanaged in driftctl scan output. Simply because it's impossible, by only reading the state, to be sure that those rules were created by terraform. Indeed terraform re-writes on apply/refresh the state with all the rules a security group has in AWS if you don't use the egress/ingress in-line blocks. We decided to warn our users if we found rules that were not created with the aws_security_group_rule resource.