Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bucket location returns EU for buckets in eu-west-1 #275

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

eliecharra
Copy link
Contributor

Q A
πŸ› Bug fix? yes
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #...
❓ Documentation no

@eliecharra eliecharra added the kind/bug Something isn't working label Feb 18, 2021
@eliecharra eliecharra requested a review from a team February 18, 2021 16:31
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #275 (2f0cc30) into main (68d0dbc) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
- Coverage   69.08%   69.06%   -0.03%     
==========================================
  Files         240      240              
  Lines        5241     5243       +2     
==========================================
  Hits         3621     3621              
- Misses       1323     1324       +1     
- Partials      297      298       +1     
Impacted Files Coverage Ξ”
pkg/remote/aws/s3_bucket_supplier.go 54.00% <0.00%> (-2.25%) ⬇️

@eliecharra eliecharra merged commit 80f4537 into main Feb 18, 2021
@eliecharra eliecharra deleted the fix_eu-west-1_buckets branch February 18, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants