Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github_team #293

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Add github_team #293

merged 1 commit into from
Feb 25, 2021

Conversation

eliecharra
Copy link
Contributor

Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #246
❓ Documentation yes

@eliecharra eliecharra added the kind/enhancement New feature or improvement label Feb 24, 2021
@eliecharra eliecharra requested a review from a team February 24, 2021 12:56
@codecov
Copy link

codecov bot commented Feb 24, 2021 •
edited
Loading

Codecov Report

Merging #293 (c7155f2) into main (da56cc9) will decrease coverage by 0.01%.
The diff coverage is 67.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
- Coverage   68.99%   68.97%   -0.02%     
==========================================
  Files         246      250       +4     
  Lines        5331     5393      +62     
==========================================
+ Hits         3678     3720      +42     
- Misses       1344     1359      +15     
- Partials      309      314       +5
Impacted Files Coverage Ξ”
pkg/remote/github/init.go 0.00% <0.00%> (ΓΈ)
pkg/remote/github/github_team_supplier.go 42.85% <42.85%> (ΓΈ)
pkg/resource/github/github_team_ext.go 66.66% <66.66%> (ΓΈ)
...ce/github/deserializer/github_team_deserializer.go 69.23% <69.23%> (ΓΈ)
pkg/iac/deserializers.go 100.00% <100.00%> (ΓΈ)
pkg/remote/github/repository.go 81.13% <100.00%> (+7.44%) ⬆️
pkg/resource/github/github_team.go 100.00% <100.00%> (ΓΈ)
... and 1 more

lotoussa
lotoussa previously approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@lotoussa lotoussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intern approve, can request another engineer review.

wbeuil
wbeuil previously approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliecharra eliecharra dismissed stale reviews from wbeuil and lotoussa via c7155f2 February 25, 2021 09:49
@wbeuil wbeuil self-requested a review February 25, 2021 09:51
@eliecharra eliecharra merged commit 4f1cd42 into main Feb 25, 2021
@eliecharra eliecharra deleted the add_github_team branch February 25, 2021 09:54
@eliecharra eliecharra linked an issue Feb 25, 2021 that may be closed by this pull request
Add support for github_team #246
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbeuil wbeuil wbeuil approved these changes

@lotoussa lotoussa lotoussa left review comments

Assignees
No one assigned
Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for github_team
3 participants
@eliecharra @wbeuil @lotoussa