Add tests for driftctl #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 69.19% 70.23% +1.04%
==========================================
Files 281 281
Lines 6149 6149
==========================================
+ Hits 4255 4319 +64
+ Misses 1542 1476 -66
- Partials 352 354 +2
|
sundowndev
previously approved these changes
Mar 31, 2021
wbeuil
reviewed
Mar 31, 2021
| ty, _ := gocty.ImpliedType(data) | ||
| val, _ := gocty.ToCtyValue(data, ty) | ||
| return &val | ||
| }(), |
There was a problem hiding this comment.
You could have written the CtyVal like we did in the filter_engine tests:
CtyVal: func() *cty.Value {
v := cty.ObjectVal(map[string]cty.Value{
"test_field": cty.StringVal("value to filter on"),
})
return &v
}(),
There was a problem hiding this comment.
Obviously π€¦π» This is waaaay more readable thanks ππ»
eliecharra
force-pushed
the
add_functional_test
branch
from
ba8f1c9
to
7c112a8
Compare
wbeuil
approved these changes
Mar 31, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add test for driftctl.go