-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish driftctl to Arch user repository #414
Conversation
Codecov Report
@@ Coverage Diff @@
## main #414 +/- ##
=======================================
Coverage 70.73% 70.73%
=======================================
Files 284 284
Lines 6396 6396
=======================================
Hits 4524 4524
Misses 1504 1504
Partials 368 368 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as for the script and the ci config, I tested it with a clone repo. Too bad there is not an easier way though ... Just two small comments about the badges
README.md
Outdated
<br> | ||
<a href="https://repology.org/project/driftctl/versions"> | ||
<img src="https://repology.org/badge/vertical-allrepos/driftctl.svg" alt="Packaging status"> | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not huge fan of having something that big as a badge. We can use their tiny badges as per the docs of repology if we really want to display actual version for each package manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know we could do that in markdown ! I'm ok with that
README.md
Outdated
@@ -6,7 +6,7 @@ | |||
<img src="https://circleci.com/gh/cloudskiff/driftctl.svg?style=shield"/> | |||
<img src="https://goreportcard.com/badge/github.com/cloudskiff/driftctl"/> | |||
<img src="https://img.shields.io/github/license/cloudskiff/driftctl"> | |||
<img src="https://img.shields.io/github/v/release/cloudskiff/driftctl"> | |||
<img src="https://img.shields.io/github/v/release/cloudskiff/driftctl?label=latest%20version"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change of label ? The word release
is enough self-explanatory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think it was unclear with the new block label, will revert this with the usage of individual labels
fbf7fe0
to
d59e6b2
Compare
d59e6b2
to
3e9cf74
Compare
Description
Add automatic publish to arch user repository.
Example pipeline can be found there : https://app.circleci.com/pipelines/github/cloudskiff/driftctl/1171/workflows/672dbdd4-d2cb-4ad1-aefe-4af1559288e4/jobs/1845