Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 367 error reporting #424

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Fix issue 367 error reporting #424

merged 1 commit into from
Apr 12, 2021

Conversation

lotoussa
Copy link
Contributor

Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #367
❓ Documentation no

Description

Fix the #381 PR.

@lotoussa lotoussa added kind/documentation Improvements or additions to documentation next-version/patch labels Apr 12, 2021
@lotoussa lotoussa added this to the v0.7.1 milestone Apr 12, 2021
@lotoussa lotoussa self-assigned this Apr 12, 2021
@lotoussa lotoussa requested a review from a team as a code owner April 12, 2021 16:23
@eliecharra eliecharra removed the kind/documentation Improvements or additions to documentation label Apr 12, 2021
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #424 (2d552be) into v0.7 (0f2ba96) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v0.7     #424      +/-   ##
==========================================
- Coverage   69.63%   69.62%   -0.02%     
==========================================
  Files         283      283              
  Lines        6126     6126              
==========================================
- Hits         4266     4265       -1     
  Misses       1507     1507              
- Partials      353      354       +1     
Impacted Files Coverage Ξ”
pkg/cmd/driftctl.go 79.59% <100.00%> (-2.05%) ⬇️

@eliecharra eliecharra merged commit 252bb60 into v0.7 Apr 12, 2021
@eliecharra eliecharra deleted the issue_367_error_reporting branch April 12, 2021 16:36
@sundowndev sundowndev mentioned this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants