Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated doc following user feedback #43

Merged
merged 3 commits into from
Dec 21, 2020
Merged

updated doc following user feedback #43

merged 3 commits into from
Dec 21, 2020

Conversation

sjourdan
Copy link
Contributor

Q A
πŸ› Bug fix? yes
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #41
❓ Documentation yes

Description

Documentation wasn't standard enough for some use cases.

Those updates worked on my fedora env, my ubuntu docker env, and validated on Windows 10

@sjourdan sjourdan added the kind/documentation Improvements or additions to documentation label Dec 19, 2020
@sjourdan sjourdan requested a review from a team as a code owner December 19, 2020 09:19
@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #43 (c09aaee) into main (8f49f5a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   67.00%   67.00%           
=======================================
  Files         146      146           
  Lines        3179     3179           
=======================================
  Hits         2130     2130           
  Misses        809      809           
  Partials      240      240           

Copy link
Contributor

@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants