add fmt check in ci

[moadibfr]

Q	A
🐛 Bug fix?	no
🚀 New feature?	no
⚠ Deprecations?	no
❌ BC Break	no
🔗 Related issues
❓ Documentation	no

Description

We had badly formated (not passed to fmt) file in main. make will create diff that add noise to PR.
I added a check on ci during tests phase to prevent PR to be merge when fmt is not ok.

[codecov]

Codecov Report

Merging #51 (4a3ef87) into main (4d9c048) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   66.93%   66.93%           
=======================================
  Files         146      146           
  Lines        3179     3179           
=======================================
  Hits         2128     2128           
  Misses        810      810           
  Partials      241      241           

Impacted Files	Coverage Δ
pkg/middlewares/aws_instance_eip.go	91.30% <ø> (ø)

[wbeuil]

Didn't know that you could use test -z to return false or true and that CircleCI would exit. Thanks :)

What I envisioned is more verbose. We could display what are the files we need to re-format just like terraform does.

- run:
      name: Enforce Go Formatted Code
      command: go fmt ./...
- run:
      name: Verify No Code Was Generated
      command: |
            if [[ -z $(git status --porcelain) ]]; then
              echo "Git directory is clean."
            else
              echo "Git directory is dirty. Run `make fmt` locally and commit any formatting fixes or generated code."
              git status --porcelain
              exit 1
            fi

This is what they do in their ci/cd pipeline.

[wbeuil]

LGTM