Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about AWS authentication #52

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Conversation

wbeuil
Copy link
Contributor

@wbeuil wbeuil commented Dec 22, 2020

Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #46
❓ Documentation yes

Description

It is possible to use driftctl with IAM role by defining a named profile.

As per AWS documentation an example could be:

# in ~/.aws/config file
[profile marketingadmin]
role_arn = arn:aws:iam::123456789012:role/marketingadminrole
source_profile = user1
region = eu-west-3 # to avoid overriding AWS_REGION setting

And then:

$ AWS_PROFILE=marketingadmin driftctl scan

@wbeuil wbeuil added the kind/documentation Improvements or additions to documentation label Dec 22, 2020
@wbeuil wbeuil requested a review from a team as a code owner December 22, 2020 17:38
@wbeuil wbeuil self-assigned this Dec 22, 2020
sjourdan
sjourdan previously approved these changes Dec 22, 2020
Copy link
Contributor

@sjourdan sjourdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #52 (c3e0bb1) into main (110813b) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   66.93%   67.00%   +0.06%     
==========================================
  Files         146      146              
  Lines        3179     3179              
==========================================
+ Hits         2128     2130       +2     
+ Misses        810      809       -1     
+ Partials      241      240       -1     
Impacted Files Coverage Ξ”
pkg/parallel_runner.go 74.46% <0.00%> (+4.25%) ⬆️

Copy link
Contributor

@moadibfr moadibfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@sjourdan sjourdan merged commit e30969a into main Dec 23, 2020
@sjourdan sjourdan deleted the doc/authentication branch December 23, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants