Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unknown attributes error in state #75

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Conversation

eliecharra
Copy link
Contributor

@eliecharra eliecharra commented Jan 6, 2021

Q A
πŸ› Bug fix? yes
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #59
❓ Documentation no

Description

This PR allow us to ignore new fields from a state generated from a newer version of terraform provider.
It allow us to read state coming from aws provider version 3.22 if we currently only support version 3.19.
This PR also changes error mgmt during state reading, if we cannot decode a part of the state, we stop execution. It prevent us to return inconsistent drift result as some resources from the state are missing.

References

@eliecharra eliecharra added the kind/bug Something isn't working label Jan 6, 2021
@eliecharra eliecharra added this to the v0.2.0 milestone Jan 6, 2021
@eliecharra eliecharra requested a review from wbeuil January 6, 2021 11:44
@eliecharra eliecharra requested a review from a team as a code owner January 6, 2021 11:44
Copy link
Contributor

@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge feature and works perfectly as intended !

@eliecharra eliecharra merged commit e131550 into main Jan 6, 2021
@eliecharra eliecharra deleted the stronger_state_reader branch January 6, 2021 12:41
@eliecharra eliecharra linked an issue Jan 6, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERRO[0009] unsupported attribute "enclave_options"
2 participants