Fix records that has the same FQDN #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage 67.03% 67.04%
=======================================
Files 146 146
Lines 3307 3314 +7
=======================================
+ Hits 2217 2222 +5
- Misses 841 842 +1
- Partials 249 250 +1
|
eliecharra
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For two records that has the same fully qualified domain name, our diff would messed up the match between them since two records could have the same FQDN but not the same type (TXT, A ...).
We decided to normalise the state resource by modifying its id in order to match what we have from the AWS provider. Thus we must have an Id of type
ZoneId_FQDN_Type_SetIdentifier.