Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash for buckets in us-east-1 #81

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Conversation

eliecharra
Copy link
Contributor

@eliecharra eliecharra commented Jan 7, 2021

Q A
πŸ› Bug fix? yes
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #73
❓ Documentation no

Description

According to AWS SDK documentation, buckets in us-east-1 region return nil in GetBucketLocation

@eliecharra eliecharra added kind/bug Something isn't working priority/0 labels Jan 7, 2021
@eliecharra eliecharra added this to the v0.2.3 milestone Jan 7, 2021
@eliecharra eliecharra requested a review from a team January 7, 2021 09:11
@eliecharra eliecharra self-assigned this Jan 7, 2021
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #81 (1a05e3e) into main (aacec19) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   67.04%   67.00%   -0.05%     
==========================================
  Files         146      146              
  Lines        3314     3316       +2     
==========================================
  Hits         2222     2222              
- Misses        842      843       +1     
- Partials      250      251       +1     
Impacted Files Coverage Ξ”
pkg/remote/aws/s3_bucket_supplier.go 52.27% <0.00%> (-2.49%) ⬇️

@eliecharra eliecharra merged commit d3c1e72 into main Jan 7, 2021
@eliecharra eliecharra deleted the fix_crash_for_s3_buckets branch January 7, 2021 09:46
@eliecharra eliecharra linked an issue Jan 7, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using docker and MFA with AWS - ERRO[0001] Unable to scan resources:
2 participants