Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update README and snyk-monitor README #454

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

agranado2k
Copy link
Contributor

Reorganise the steps to make them clear to the user.

  • Tests written and linted ℹ︎
  • Documentation written ℹ︎
  • Commit history is tidy ℹ︎

What this does

This PR is updating the README and snyk-monitor/README, reorganising the steps when creating the snyk-monitor secret.

More information

@agranado2k agranado2k self-assigned this Apr 22, 2020
@agranado2k agranado2k marked this pull request as ready for review April 22, 2020 16:07
@agranado2k agranado2k requested a review from a team as a code owner April 22, 2020 16:07
Copy link
Contributor

@ivanstanev ivanstanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One thing to note, could we name the commit chore:? I know it's technically more accurate to be docs but we don't actually use it and instead we use chore for anything non-functional (docs, comments, CI stuff, etc.).

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@agranado2k agranado2k force-pushed the docs/update_readme_install_process branch from 167d66b to 21f42f6 Compare April 22, 2020 16:45
Reorganise the steps to make them clear to the user.
@agranado2k agranado2k force-pushed the docs/update_readme_install_process branch from 21f42f6 to 29a2bf2 Compare April 23, 2020 09:25
@agranado2k agranado2k changed the title docs: Update README and snyk-monitor README chore: Update README and snyk-monitor README Apr 23, 2020
@agranado2k agranado2k merged commit cabc8d1 into staging Apr 23, 2020
@agranado2k agranado2k deleted the docs/update_readme_install_process branch April 23, 2020 09:32
@snyksec
Copy link

snyksec commented Apr 28, 2020

🎉 This PR is included in version 1.27.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants