fix: upgrade K8s client library to add Keep Alive to watches #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been an outstanding issue for over a month, especially prevalent in AKS. After some inactivity in the cluster, the persistent connection to the K8s API server got interrupted and was never able to recover. This new fix in the K8s client library puts a 30s keep alive to the Watch connection so that it does not get interrupted.
ivanstanev
force-pushed
the
fix/keep-alive-informer
branch
from
53ecbf1
to
cf44c9b
Compare
This adds a new requirement of having extra environment variables. They are used to create imagePullSecrets to use for our fixtures, thus avoiding getting rate limited by Docker Hub when these images need to be pulled by KinD. This does not solve the rate limiting from inside snyk-monitor using skopeo, which we've seen only very rarely. If that happens then the workaround is to set the dockercfg.json of snyk-monitor with auth details for Docker Hub.
We deploy a Pod in our integration tests using the --generator flag of kubectl. Since 1.18 of kubectl, it seems that this flag has been deprecated and is no longer used: "has no effect and will be removed in the future". This was caught by our tests because we try to use the latest version of kubectl, so breaking changes like this will surface.
|
Expected release notes (by @ivanstanev) fixes: others (will not be included in Semantic-Release notes):
|
|
🎉 This PR is included in version 1.50.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This has been an outstanding issue for over a month, especially prevalent in AKS. After some inactivity in the cluster, the persistent connection to the K8s API server got interrupted and was never able to recover.
This new fix in the K8s client library puts a 30s keep alive to the Watch connection so that it does not get interrupted.
More information