fix: use custom version compare function to support multiple version string compare groups

[SteveShani]

This fixes an issue where an exception would occur when a python dependency had a version that did not conform to semver specs, such as 1.18.3.9

• Ready for review
• Follows CONTRIBUTING rules
• Reviewed by Snyk internal team

[danlucian]

I would extract the following logic to its function, aiming for a small readability win:

function compareArrays(v1: any[], v2: any[]): number {
  const maxLength = Math.max(v1.length, v2.length);

  for (let i = 0; i < maxLength; i++) {
    const element1 = v1[i] || 0;
    const element2 = v2[i] || 0;

    if (element1 < element2) {
      return 1;
    }

    if (element1 > element2) {
      return -1;
    }
  }

  return 0;
}

The any type should be concrete, just used it for the sake of the example.

What do you say?

[SteveShani]

I can do that. To me the function is readable but that's subjective.

Regarding the concrete type, the right answer would be Array[Comparable] but I don't think Typescript has a Comparable type. I'll stick with number or string for now as that's what's likely to appear.

[snyk-team-unify]

🎉 This PR is included in version 6.12.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀