Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/testing-prs #138

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore/testing-prs #138

wants to merge 2 commits into from

Conversation

shirlupo
Copy link

DO NOT MERGE

Copy link

@snyk-scm-platform-test snyk-scm-platform-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

routes/index.js Show resolved Hide resolved
Copy link

@snyk-scm-platform-test snyk-scm-platform-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

routes/index.js Show resolved Hide resolved
Copy link

@snyk-scm-platform-test snyk-scm-platform-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

routes/index.js Show resolved Hide resolved
Copy link

@snyk-scm-platform-test snyk-scm-platform-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

routes/index.js Show resolved Hide resolved
@snyk-scm-platform-test
Copy link

This is a comment on the pull request.

Copy link

@snyk-scm-platform-test snyk-scm-platform-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitting the review.

routes/index.js Show resolved Hide resolved
Copy link

@snyk-scm-platform-test snyk-scm-platform-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitting the review.

routes/index.js Show resolved Hide resolved
routes/index.js Show resolved Hide resolved
routes/index.js Show resolved Hide resolved
Copy link

@snyk-scm-platform-test snyk-scm-platform-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitting the review.

routes/index.js Show resolved Hide resolved
routes/index.js Show resolved Hide resolved
Copy link

@snyk-scm-platform-test snyk-scm-platform-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting the review.

routes/index.js Show resolved Hide resolved
routes/index.js Show resolved Hide resolved
Copy link

@snyk-scm-platform-test snyk-scm-platform-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

routes/index.js Show resolved Hide resolved
routes/index.js Show resolved Hide resolved
Copy link

@snyk-scm-platform-test snyk-scm-platform-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

routes/index.js Show resolved Hide resolved
@@ -62,7 +61,7 @@ function parse(todo) {
time = time.replace(/\n$/, '');

var period = hms(time);

var shir = "DoNotMerge";
console.log('period: ' + period);

// remove it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new isuee on line 67

Copy link

@snyk-scm-platform-test snyk-scm-platform-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

Comment on lines 144 to 145
// ** express turns the cookie key to lowercase **
exports.current_user = function (req, res, next) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new isuee on line 144-145

@@ -6,7 +6,6 @@ var User = mongoose.model('User');
var hms = require('humanize-ms');
var ms = require('ms');
var streamBuffers = require('stream-buffers');
var readline = require('readline');
var moment = require('moment');
var exec = require('child_process').exec;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new isuee on line 11

Copy link

@snyk-scm-platform-test snyk-scm-platform-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

Comment on lines 144 to 145
// ** express turns the cookie key to lowercase **
exports.current_user = function (req, res, next) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new isuee on line 144-145

@@ -6,7 +6,6 @@ var User = mongoose.model('User');
var hms = require('humanize-ms');
var ms = require('ms');
var streamBuffers = require('stream-buffers');
var readline = require('readline');
var moment = require('moment');
var exec = require('child_process').exec;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new isuee on line 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants