feat: code action for OSS via LS in IntelliJ [IDE-284] #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
teodora-sandu
force-pushed
the
feat/code-action-oss-ls
branch
2 times, most recently
from
b52bb80
to
0e2788b
Compare
bastiandoetsch
approved these changes
Jun 26, 2024
|
Yep @bastiandoetsch it's linked in the PR description too but here it is: snyk/snyk-ls#511. I'll wait to get that merged and released before I merge this PR |
|
The LS change is merged 馃殌 |
|
Just need to get snyk/cli#5349 merged and then this can be merged! |
teodora-sandu
force-pushed
the
feat/code-action-oss-ls
branch
from
0e2788b
to
2b1988c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the existing
codeActionsreturned via the LS for OSS with quickfix actions that tell us what version to upgrade a package to.The only difference is that the new "OSS via LS" code actions have Snyk Learn actions too and we return quickfix code actions for all possible upgrade paths, rather than just the one.
To review, build snyk/snyk-ls#511 and follow the review instructions there.
Checklist
馃毃After having merged, please update the CLI go.mod to pull in latest language server.
Screenshots / GIFs
This was tested by building
snyk-lsfrom snyk/snyk-ls#511 and then the CLI with asnyk-lsreplace directive, then changing the IntelliJ sandbox generated from this branch to point at the local CLI. Make sure to enable the registry flag.The tests were run on https://github.com/snyk-labs/snyk-chat-goof.
Before:
After: