fix: don't double scan on startup, handle feature flags better #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastiandoetsch
changed the title
when opening a project, the project startup activity is registering all content roots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, at startup, two scans were triggered due to LS triggering one automatically during startup and IntelliJ triggering one manually on opening a project.
Now, no scan is manually triggered when opening a project.
In addition to using the feature flag API endpoint, consistentIgnores status is now detected when processing scan results. When an issue is ignored, this can only come from the feature being on, so it's switched on in IntelliJ. This should make sure that whenever ignored issues are transmitted, IntelliJ filters & displays them correctly.
Fixes code vision not displaying.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!