Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [OSM-2206] skip unresolved local packages #255

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

gemaxim
Copy link
Contributor

@gemaxim gemaxim commented Dec 22, 2024

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Handles errors for a requirement line that can't be parsed.
If --skip-unresolved (allowMissing) is true, the lines that throw errors are ignored.

@gemaxim gemaxim requested a review from a team as a code owner December 22, 2024 22:55
@gemaxim gemaxim force-pushed the fix/OSM-2206/skip-unresolved-local-pkgs branch 2 times, most recently from 50b3b49 to cb9ebae Compare December 22, 2024 22:57
@@ -924,21 +947,6 @@ describe('inspect', () => {
},
],
},
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed as Jinja2 always gets installed with the latest version for this testcase. It's not sustainable to update the testcase with the latest version always.
Can be moved to another PR.

@gemaxim gemaxim force-pushed the fix/OSM-2206/skip-unresolved-local-pkgs branch 2 times, most recently from d18af22 to c5c5241 Compare December 23, 2024 07:23
@gemaxim gemaxim force-pushed the fix/OSM-2206/skip-unresolved-local-pkgs branch 3 times, most recently from 5249872 to f0062ad Compare December 23, 2024 13:39
@gemaxim gemaxim force-pushed the fix/OSM-2206/skip-unresolved-local-pkgs branch 4 times, most recently from b3bd488 to 9b1ebd6 Compare January 9, 2025 07:21
@gemaxim gemaxim force-pushed the fix/OSM-2206/skip-unresolved-local-pkgs branch from 9b1ebd6 to 19e6766 Compare January 9, 2025 07:32
@gemaxim gemaxim merged commit e8b6e84 into main Jan 9, 2025
25 checks passed
@gemaxim gemaxim deleted the fix/OSM-2206/skip-unresolved-local-pkgs branch January 9, 2025 07:49
@snyksec
Copy link

snyksec commented Jan 9, 2025

🎉 This PR is included in version 2.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants