update to zig version 0.12.0-dev.1297+a9e66ed73; Fix compile errors on Windows #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -202,7 +207,7 @@ pub const DtMachine = struct { | |||
|
|
|||
| // Removes and returns top N values from the stack from oldest to youngest. Last index is the most recent, 0 is the oldest. | |||
| pub fn popN(self: *DtMachine, comptime n: comptime_int) ![n]Val { | |||
| var vals: [n]Val = .{}; | |||
| var vals: [n]Val = undefined; | |||
There was a problem hiding this comment.
note to self: Was this required?
| @@ -28,6 +25,10 @@ pub fn main() !void { | |||
| const stdinPiped = !std.io.getStdIn().isTty(); | |||
| const stdoutPiped = !std.io.getStdOut().isTty(); | |||
|
|
|||
| if (@import("builtin").os.tag == .windows) { | |||
| _ = std.os.windows.kernel32.SetConsoleOutputCP(65001); | |||
There was a problem hiding this comment.
note to self: What is the output and should I do something with it?
|
Thanks again for taking a look at dt, and for sharing these changes I'll merge this at some point when I'm ready to do some follow-up work on tests/build/ci |
booniepepper
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.