-
Notifications
You must be signed in to change notification settings - Fork 444
Add support for consul shared configuration #305
Conversation
FYI - I'm in discussion with Netflix to move Exhibitor to its own repo so that it get better community support. Please stayed tuned. |
Step 1: Fork |
Would love to see this mainline, but as @thesquelched said - fork! |
Successfully using this on a dev environment. No issues reported so far. |
Any chance to see this merged ? |
I very much doubt it |
@supernovae and I have this code running on 22 mesos clusters and counting with this additional patch: https://github.com/flyinprogrammer/exhibitor/commit/d1cd3c1d30b1d5dba405c380c1fa7e1dec70ab1f for better or worse lol -- thanks @thesquelched for writing this, you're saving our 🥓 tomorrow night! |
I'll try to update the PR today with that @flyinprogrammer |
We (@supernovae & @flyinprogrammer) are collecting thousands of sessions currently, can deletion of redundant sessions be implemented? |
dce5900
to
d746911
Compare
@flyinprogrammer updated to include your library updates (and to rebase to remove merge conflicts). @nickwales can you give me any more details for the sessions issue? |
@thesquelched sure, we're monitoring the telemetry data and there was a bump in session creation without a similar jump in session deletion at the time we started using the consul backend. Image of how it looks in datadog currently: http://imgur.com/a/ti35J One of our clusters currently has 31818 sessions, 31145 of those have the name 'exhibitor'. Let me know if there's anything else you need! |
@nickwales yeah, I'm an idiot. I never bothered to destroy the sessions after releasing locks. I've added that, as well as adding a TTL on sessions so that they don't last forever if something goes wrong. Let me know if it works for you. |
Oh, and I confirmed that my tests (without destroying sessions) leave sessions laying around after changing the config, so that's almost certainly the issue. I modified the tests to check that sessions aren't left laying around anymore. |
Add consul as a shared config provider. Fixes soabase#280
a5e9cfa
to
6d3e3c0
Compare
Awesome, I'll get @flyinprogrammer to upgrade immediately 🥇 |
Add consul as a shared config provider. The relevant CLI options are:
Fixes #280