Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs introduced in PR#2 #3

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

strega-nil
Copy link
Contributor

@strega-nil strega-nil commented Nov 19, 2021

nicole is a dummy

@ThePhD
Copy link
Contributor

ThePhD commented Nov 19, 2021

... Wait a second, it pushed here? Just directly???

I was gonna send a diff or something. Ah, well, just lemme know if it looks okay, I modified it slightly and tried to make it work better for Windows! (Most of the tests compile and run now, modulo a known bug with large structs.)

@ThePhD ThePhD self-assigned this Nov 19, 2021
@ThePhD ThePhD added enhancement New feature or request 👷‍♀️ build system Fixing, improving, or otherwise changing the build system 🙇‍♀️ thank you we very much appreciate your help here labels Nov 19, 2021
@strega-nil
Copy link
Contributor Author

@ThePhD if you want to just post a diff, you can either:

  • open a PR against my branch, or
  • git format-patch --stdout HEAD^ (with N ^'s for however many commits you needed) and then copy-pasting that into gh here

@ThePhD
Copy link
Contributor

ThePhD commented Nov 22, 2021

Ah, alright. Gotcha! I'll do that next time.

This one okay-to-merge, now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👷‍♀️ build system Fixing, improving, or otherwise changing the build system enhancement New feature or request 🙇‍♀️ thank you we very much appreciate your help here
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants