fix: set mysql image version #69
Conversation
|
Warning Review failedThe pull request is closed. WalkthroughThis update integrates a new database project into the solution, refines the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- FIAP.TechChallenge.ByteMeBurger.sln (2 hunks)
- README.md (1 hunks)
- database/Dockerfile (1 hunks)
- docker-compose.yml (2 hunks)
- src/FIAP.TechChallenge.ByteMeBurger.Api/Program.cs (2 hunks)
Additional Context Used
LanguageTool (1)
README.md (1)
Near line 45: Possible missing comma found.
Context: ...ase with fake data and test some of the endpoints use the [FIAP_TechChallenge_ByteMeBurge...
Markdownlint (12)
README.md (12)
17: Expected: 1; Actual: 2
Multiple consecutive blank lines
35: Expected: 1; Actual: 2
Multiple consecutive blank lines
39: Expected: 1; Actual: 2
Multiple consecutive blank lines
53: Expected: 1; Actual: 2
Multiple consecutive blank lines
5: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
8: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
10: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
12: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
18: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
20: null
Fenced code blocks should be surrounded by blank lines
13: null
Lists should be surrounded by blank lines
19: null
Lists should be surrounded by blank lines
Path-based Instructions (1)
src/FIAP.TechChallenge.ByteMeBurger.Api/Program.cs (1)
Pattern
**/*.cs: Validate all files and structures against Domain Driven Design principles and Ports & Adapters architecture pattern.
Additional comments not posted (5)
database/Dockerfile (1)
2-2: Ensure MySQL version 8.3.0 is compatible with other project dependencies.docker-compose.yml (1)
36-36: Updated service tag aligns with project naming conventions.README.md (1)
37-37: Updated health check URL reflects the new endpoint.src/FIAP.TechChallenge.ByteMeBurger.Api/Program.cs (1)
98-98: Updated health check endpoint path to/healthzaligns with standard practices.FIAP.TechChallenge.ByteMeBurger.sln (1)
59-64: Addition of the new database project to the solution file.
|
|
||
| # NOTE: use of "mysql_native_password" is not recommended: https://dev.mysql.com/doc/refman/8.0/en/upgrading-from-previous-series.html#upgrade-caching-sha2-password | ||
| # (this is just an example, not intended to be a production configuration) | ||
| CMD ["mysqld", "--mysql-native-password=ON"] |
There was a problem hiding this comment.
Consider the security implications of using mysql_native_password.
It's recommended to use more secure authentication methods than mysql_native_password, especially for production environments. Consider alternatives such as caching_sha2_password.
docker-compose.yml
Outdated
| @@ -27,16 +26,14 @@ | |||
| - MySqlSettings__UserId=${MYSQL_USERID} | |||
| - MySqlSettings__Password=${MYSQL_PASSWORD} | |||
| - ASPNETCORE_ENVIRONMENT=Development | |||
| - Serilog__Write__To__2__Args__serverUr=http://seq:5341 | |||
There was a problem hiding this comment.
Correct the typo in the Serilog server URL.
- Serilog__Write__To__2__Args__serverUr=http://seq:5341
+ Serilog__Write__To__2__Args__serverUrl=http://seq:5341Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| - Serilog__Write__To__2__Args__serverUr=http://seq:5341 | |
| - Serilog__Write__To__2__Args__serverUrl=http://seq:5341 |
README.md
Outdated
| > [http://localhost:8080/healthz](http://localhost:8080/healthz) | ||
|
|
||
|
|
||
| 5. Testing |
There was a problem hiding this comment.
Add a comma for clarity in the testing section.
- To verify the existing endpoints go to
+ To verify the existing endpoints, go toCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| 5. Testing | |
| 5. Testing | |
| To verify the existing endpoints, go to |
italopessoa
force-pushed
the
fix_docker_mysql_version
branch
from
3d39960
to
30e6d28
Compare
italopessoa
force-pushed
the
fix_docker_mysql_version
branch
from
30e6d28
to
7a13e20
Compare
No description provided.