This repository has been archived by the owner on Jul 28, 2020. It is now read-only.
Hooks useTheme #786
Merged
Hooks useTheme #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conor-cafferkey-sociomantic
approved these changes
Jan 25, 2019
damian-rodriguez-sociomantic
approved these changes
Jan 28, 2019
There was a problem hiding this comment.
LGTM; just a small note; should we add also this in this PR or we keep it separate?
|
Yeah would be good to get that in too. But I guess it should be a separate PR |
|
This is Awesome 👍 👍 |
mahmoud-zakria-sociomantic
approved these changes
Jan 28, 2019
conor-cafferkey-sociomantic
approved these changes
Jan 28, 2019
Closed
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here:
createCssMaputils/customHookscontaininguseThemethat builds cssMapAfter each component is converted to functions that are using hooks,
useThemeshould be called instead of currentcreateCssMapto generate cssMap