refactor: remove indexof dependency

This is a polyfill for indexOf(), which we use literally everywhere else.
socketio · Apr 16, 2020 · 27fa694 · 27fa694
1 parent 804e871
commit 27fa694
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/lib/socket.js b/lib/socket.js
@@ -1,7 +1,6 @@
 const transports = require("./transports/index");
 const Emitter = require("component-emitter");
 const debug = require("debug")("engine.io-client:socket");
-const index = require("indexof");
 const parser = require("engine.io-parser");
 const parseuri = require("parseuri");
 const parseqs = require("parseqs");
@@ -643,7 +642,7 @@ class Socket extends Emitter {
     let i = 0;
     const j = upgrades.length;
     for (; i < j; i++) {
-      if (~index(this.transports, upgrades[i]))
+      if (~this.transports.indexOf(upgrades[i]))
         filteredUpgrades.push(upgrades[i]);
     }
     return filteredUpgrades;

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -28,7 +28,6 @@
     "debug": "~4.1.0",
     "engine.io-parser": "~4.0.0-alpha.0",
     "has-cors": "1.1.0",
-    "indexof": "0.0.1",
     "parseqs": "0.0.5",
     "parseuri": "0.0.5",
     "ws": "~7.2.1",