Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INVALID_STATE_ERR: DOM Exception 11 #589

Closed
xosofox opened this issue Dec 1, 2017 · 3 comments
Closed

INVALID_STATE_ERR: DOM Exception 11 #589

xosofox opened this issue Dec 1, 2017 · 3 comments

Comments

@xosofox
Copy link

xosofox commented Dec 1, 2017

xhr.responseType = 'arraybuffer';

Looks like this line can be made responsible for creating an Exception in Android 4.x browsers.

Would it be an option to try/catch this one as well?

Unfortunately, there is no way to reproduce this right now - but we see it happening when logging users' JS client errors

@darrachequesne
Copy link
Member

Well, I guess we could include it in the try .. catch above, but I'm afraid the client would not be able to correctly parse the message.

It seems the tests pass under Android 4.4 though: https://travis-ci.org/socketio/engine.io-client/jobs/309206559

@xosofox
Copy link
Author

xosofox commented Dec 4, 2017

As said, I cannot reproduce this either - it is just coming up in our client JS logs.
I'm assuming that the clients fail to parse the message right now anyway...

I might try/catch it, roll it out and check with the logs again

xosofox added a commit to xosofox/engine.io-client that referenced this issue Dec 12, 2017
The line can cause exceptions on Android 4.x in certain circumstances.

Unfortunately, not reproducible but only visible when logging client errors in production, see socketio#589
@xosofox
Copy link
Author

xosofox commented Dec 12, 2017

Update: I rolled out a "fixed" version with the offending line in a try/catch and I DO have less/no client errors of this type anymore. Interestingly, there are no other, "new" errors, so it looks like whatever happens with the messages then, seems to work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants