-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INVALID_STATE_ERR: DOM Exception 11 #589
Comments
Well, I guess we could include it in the It seems the tests pass under Android 4.4 though: https://travis-ci.org/socketio/engine.io-client/jobs/309206559 |
As said, I cannot reproduce this either - it is just coming up in our client JS logs. I might try/catch it, roll it out and check with the logs again |
The line can cause exceptions on Android 4.x in certain circumstances. Unfortunately, not reproducible but only visible when logging client errors in production, see socketio#589
Update: I rolled out a "fixed" version with the offending line in a try/catch and I DO have less/no client errors of this type anymore. Interestingly, there are no other, "new" errors, so it looks like whatever happens with the messages then, seems to work fine. |
engine.io-client/lib/transports/polling-xhr.js
Line 247 in 90f4d17
Looks like this line can be made responsible for creating an Exception in Android 4.x browsers.
Would it be an option to try/catch this one as well?
Unfortunately, there is no way to reproduce this right now - but we see it happening when logging users' JS client errors
The text was updated successfully, but these errors were encountered: