Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option: add localAddress option #487

Closed
wants to merge 1 commit into from
Closed

option: add localAddress option #487

wants to merge 1 commit into from

Conversation

magicdawn
Copy link
Contributor

No description provided.

@darrachequesne
Copy link
Member

Hi! Could you please

  • fix the conflicts
  • add the option in the documentation
  • add a test case
    ?

Thanks a lot!

@darrachequesne darrachequesne mentioned this pull request Oct 20, 2016
Closed
darrachequesne pushed a commit that referenced this pull request Oct 31, 2016
@magicdawn @darrachequesne
[feature] add localAddress option (#487)
9cfc626
@darrachequesne
Copy link
Member

Merged as 9cfc626. Thanks!

@darrachequesne darrachequesne added this to the 1.8.0 milestone Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@magicdawn @darrachequesne