Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test in browsers #527

Merged
merged 2 commits into from
Dec 30, 2016
Merged

Test in browsers #527

merged 2 commits into from
Dec 30, 2016

Conversation

darrachequesne
Copy link
Member

Following #526.

Note: is gulp really needed?

@darrachequesne darrachequesne merged commit 54c0438 into socketio:master Dec 30, 2016
@darrachequesne darrachequesne deleted the chore/zuul-tests2 branch December 30, 2016 16:18
@darrachequesne
Copy link
Member Author

Hmm... not sure why the tests are failing in the browser:

  • should properly parse a host without port
  • should properly parse an IPv6 host without port (1/2)
  • should properly parse an IPv6 host without brace

darrachequesne added a commit to darrachequesne/engine.io-client that referenced this pull request Jan 22, 2017
@darrachequesne
Revert "[chore] Actually run tests in Saucelabs (socketio#527)"
f53e732 
This reverts commit 54c0438.
@darrachequesne darrachequesne added this to the 2.0.0 milestone Jan 23, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@darrachequesne